task_work: use try_cmpxchg in task_work_add, task_work_cancel_match and task_work_run
authorUros Bizjak <ubizjak@gmail.com>
Tue, 23 Aug 2022 15:26:32 +0000 (17:26 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 04:55:10 +0000 (21:55 -0700)
commit5fdfa161b2043001f82cbce49e87e8e9f581d510
treee3326441233ff70650de4244502dd08ea438cdd1
parent977bbf4385fc64986f22b024858071a35c481a8a
task_work: use try_cmpxchg in task_work_add, task_work_cancel_match and task_work_run

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
task_work_add, task_work_cancel_match and task_work_run.  x86 CMPXCHG
instruction returns success in ZF flag, so this change saves a compare
after cmpxchg (and related move instruction in front of cmpxchg).

Also, atomic_try_cmpxchg implicitly assigns old *ptr value to "old"
when cmpxchg fails, enabling further code simplifications.

The patch avoids extra memory read in case cmpxchg fails.

Link: https://lkml.kernel.org/r/20220823152632.4517-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/task_work.c