fs: simplify misleading code to remove ambiguity regarding ihold()/iput()
authorLuís Henriques <lhenriques@suse.de>
Thu, 28 Sep 2023 15:23:41 +0000 (16:23 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 19 Oct 2023 09:02:48 +0000 (11:02 +0200)
commit6036c5f1317526890925576f0efcbc427a32a2ae
tree92aa6e21c454e5acf60f7eb83eccf11a0d96bfd3
parent85fadf89e5708d74c4923e9ceeca4b9df0e000bb
fs: simplify misleading code to remove ambiguity regarding ihold()/iput()

Because 'inode' is being initialised before checking if 'dentry' is negative
it looks like an extra iput() on 'inode' may happen since the ihold() is
done only if the dentry is *not* negative.  In reality this doesn't happen
because d_is_negative() is never true if ->d_inode is NULL.  This patch only
makes the code easier to understand, as I was initially mislead by it.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
Link: https://lore.kernel.org/r/20230928152341.303-1-lhenriques@suse.de
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/namei.c