leds: Convert all platform drivers to return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 17 Sep 2023 13:09:47 +0000 (15:09 +0200)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:35 +0000 (11:28 +0000)
commit6061302092305a0584aacf0d82a9d5e66653884c
tree82e9d76907780600e6825ab75fc6ee4cbdcdb850
parenteccc489ef68d70cfdd850ba24933f1febbf2893e
leds: Convert all platform drivers to return void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

All platform drivers below drivers/leds/ unconditionally return zero in
their remove callback and so can be converted trivially to the variant
returning void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230917130947.1122198-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
26 files changed:
drivers/leds/blink/leds-lgm-sso.c
drivers/leds/flash/leds-aat1290.c
drivers/leds/flash/leds-ktd2692.c
drivers/leds/flash/leds-max77693.c
drivers/leds/flash/leds-mt6360.c
drivers/leds/flash/leds-qcom-flash.c
drivers/leds/flash/leds-rt8515.c
drivers/leds/flash/leds-sgm3140.c
drivers/leds/leds-88pm860x.c
drivers/leds/leds-adp5520.c
drivers/leds/leds-clevo-mail.c
drivers/leds/leds-da903x.c
drivers/leds/leds-da9052.c
drivers/leds/leds-lm3533.c
drivers/leds/leds-mc13783.c
drivers/leds/leds-mlxreg.c
drivers/leds/leds-mt6323.c
drivers/leds/leds-nic78bx.c
drivers/leds/leds-powernv.c
drivers/leds/leds-rb532.c
drivers/leds/leds-regulator.c
drivers/leds/leds-sc27xx-bltc.c
drivers/leds/leds-sunfire.c
drivers/leds/leds-wm831x-status.c
drivers/leds/leds-wm8350.c
drivers/leds/rgb/leds-qcom-lpg.c