um: Remove strlcpy declaration
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 3 Jul 2023 16:06:41 +0000 (16:06 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 27 Jul 2023 15:51:06 +0000 (08:51 -0700)
commit61ce78f29a694772c3b2c5c749589682dbdfec2d
treeafc9b7a4dc3ab8901917aea3d546cb58af653ecf
parent630fdd592912614a72d00026fdadad72d9ef62eb
um: Remove strlcpy declaration

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230703160641.1790935-1-azeemshaikh38@gmail.com
Signed-off-by: Kees Cook <keescook@chromium.org>
arch/um/include/shared/user.h
arch/um/os-Linux/umid.c