ssi-sd: Make devices picking up backends unavailable with -device
authorMarkus Armbruster <armbru@redhat.com>
Wed, 24 Oct 2018 06:50:16 +0000 (07:50 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Wed, 24 Oct 2018 06:50:16 +0000 (07:50 +0100)
commit61e9e3cb45c378c1e705d67ff66e5936249539c8
tree03410509937eb441ad1c16fa0854bb90464144fb
parent13399aad4fa87b2878c49d02a5d3bafa6c966ba3
ssi-sd: Make devices picking up backends unavailable with -device

Device models aren't supposed to go on fishing expeditions for
backends.  They should expose suitable properties for the user to set.
For onboard devices, board code sets them.

Device ssi-sd picks up its block backend in its init() method with
drive_get_next() instead.  This mistake is already marked FIXME since
commit af9e40a.

Unset user_creatable to remove the mistake from our external
interface.  Since the SSI bus doesn't support hotplug, only -device
can be affected.  Only certain ARM machines have ssi-sd and provide an
SSI bus for it; this patch breaks -device ssi-sd for these machines.
No actual use of -device ssi-sd is known.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-id: 20181009060835.4608-1-armbru@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/sd/ssi-sd.c