mcb: fix error handling for different scenarios when parsing
authorSanjuán García, Jorge <Jorge.SanjuanGarcia@duagon.com>
Thu, 19 Oct 2023 14:15:34 +0000 (14:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2023 21:04:02 +0000 (23:04 +0200)
commit63ba2d07b4be72b94216d20561f43e1150b25d98
tree9fd424353071293932c3157bf8b715736ccd0efc
parent28cbfe09ff20964d293cd7af10d2ec0782cf86cb
mcb: fix error handling for different scenarios when parsing

chameleon_parse_gdd() may fail for different reasons and end up
in the err tag. Make sure we at least always free the mcb_device
allocated with mcb_alloc_dev().

If mcb_device_register() fails, make sure to give up the reference
in the same place the device was added.

Fixes: 728ac3389296 ("mcb: mcb-parse: fix error handing in chameleon_parse_gdd()")
Cc: stable <stable@kernel.org>
Reviewed-by: Jose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@duagon.com>
Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Link: https://lore.kernel.org/r/20231019141434.57971-2-jorge.sanjuangarcia@duagon.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mcb/mcb-core.c
drivers/mcb/mcb-parse.c