ASoC: codecs: rt5640: Simplify mclk initialization
authorCezary Rojewski <cezary.rojewski@intel.com>
Wed, 21 Feb 2024 15:25:15 +0000 (16:25 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 21 Feb 2024 16:26:21 +0000 (16:26 +0000)
commit6413849b678b04e30b5c938e344e653c31a5f73b
tree5471f6034ef44ad752cc961f904a0558dc882972
parentf76de61ad1eb725cc05727377ccd4adda336b822
ASoC: codecs: rt5640: Simplify mclk initialization

Most of clk_xxx() functions do check if provided clk-pointer is
non-NULL. These do not check if the pointer is an error-pointer.
Providing such to a clk_xxx() results in a panic.

rt5640_set_dai_sysclk() is an example of that - clk_set_rate() is not
guarded by IS_ERR().

By utilizing _optional() variant of devm_clk_get() the driver code is
both simplified and more robust. There is no need to remember about
IS_ERR(clk) checks each time mclk is accessed.

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://msgid.link/r/20240221152516.852353-6-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5640.c