aio: Prefer struct_size over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sun, 19 Sep 2021 09:45:39 +0000 (11:45 +0200)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 20 Oct 2021 23:24:31 +0000 (18:24 -0500)
commit6446c4fb12ecc130ed9b4333372426b305a35e2b
tree9c41c2baaf0b7980a74c8cdd09e1a5507701eddb
parent98b160c828f312955daa94713a5fca595400b8c3
aio: Prefer struct_size over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + size * count" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
fs/aio.c