xfs: clean up xfs_bui_item_recover iget/trans_alloc/ilock ordering
authorDarrick J. Wong <darrick.wong@oracle.com>
Sat, 26 Sep 2020 00:39:50 +0000 (17:39 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 7 Oct 2020 15:40:28 +0000 (08:40 -0700)
commit64a3f3315bc60f710a0a25c1798ac0ea58c6fa1f
tree906416ab193a630c1e528479d065979746a494f7
parent919522e89f8e71fc6a8f8abe17be4011573c6ea0
xfs: clean up xfs_bui_item_recover iget/trans_alloc/ilock ordering

In most places in XFS, we have a specific order in which we gather
resources: grab the inode, allocate a transaction, then lock the inode.
xfs_bui_item_recover doesn't do it in that order, so fix it to be more
consistent.  This also makes the error bailout code a bit less weird.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/xfs_bmap_item.c