tcp_metrics: optimize tcp_metrics_flush_all()
authorEric Dumazet <edumazet@google.com>
Fri, 22 Sep 2023 22:03:56 +0000 (22:03 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 3 Oct 2023 08:05:22 +0000 (10:05 +0200)
commit6532e257aa73645e28dee5b2232cc3c88be62083
tree45163de0778a35d7a377062daa245e50c54464f5
parenta135798e6e200ecb2f864cecca6d257ba278370c
tcp_metrics: optimize tcp_metrics_flush_all()

This is inspired by several syzbot reports where
tcp_metrics_flush_all() was seen in the traces.

We can avoid acquiring tcp_metrics_lock for empty buckets,
and we should add one cond_resched() to break potential long loops.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/tcp_metrics.c