net: dsa: mt7530: do not set priv->p5_interface on mt7530_setup_port5()
authorArınç ÜNAL <arinc.unal@arinc9.com>
Mon, 22 Jan 2024 05:35:57 +0000 (08:35 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 Jan 2024 02:04:12 +0000 (18:04 -0800)
commit6537973f2a5dc3e83a424142366fd15a2b97199f
treef895530d57aee856295a96eb1359a015720e579d
parent152f8e8e7458f39720886c8ed1d55f456096499e
net: dsa: mt7530: do not set priv->p5_interface on mt7530_setup_port5()

Running mt7530_setup_port5() from mt7530_setup() used to handle all cases
of configuring port 5, including phylink.

Setting priv->p5_interface under mt7530_setup_port5() makes sure that
mt7530_setup_port5() from mt753x_phylink_mac_config() won't run.

The commit ("net: dsa: mt7530: improve code path for setting up port 5")
makes so that mt7530_setup_port5() from mt7530_setup() runs only on
non-phylink cases.

Get rid of unnecessarily setting priv->p5_interface under
mt7530_setup_port5() as port 5 phylink configuration will be done by
running mt7530_setup_port5() from mt753x_phylink_mac_config() now.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240122-for-netnext-mt7530-improvements-1-v3-6-042401f2b279@arinc9.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mt7530.c