f2fs: Fix deadlock in f2fs_gc() context during atomic files handling
authorSahitya Tummala <stummala@codeaurora.org>
Wed, 13 Nov 2019 10:31:03 +0000 (16:01 +0530)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 19 Nov 2019 22:41:21 +0000 (14:41 -0800)
commit677017d196ba2a4cfff13626b951cc9a206b8c7c
treee892d3c5ea3e54572efc436cde028bccff138ee0
parentc45d6002ff7a322022560e9b19ad867b01fec77f
f2fs: Fix deadlock in f2fs_gc() context during atomic files handling

The FS got stuck in the below stack when the storage is almost
full/dirty condition (when FG_GC is being done).

schedule_timeout
io_schedule_timeout
congestion_wait
f2fs_drop_inmem_pages_all
f2fs_gc
f2fs_balance_fs
__write_node_page
f2fs_fsync_node_pages
f2fs_do_sync_file
f2fs_ioctl

The root cause for this issue is there is a potential infinite loop
in f2fs_drop_inmem_pages_all() for the case where gc_failure is true
and when there an inode whose i_gc_failures[GC_FAILURE_ATOMIC] is
not set. Fix this by keeping track of the total atomic files
currently opened and using that to exit from this condition.

Fix-suggested-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/f2fs.h
fs/f2fs/file.c
fs/f2fs/segment.c