KVM: arm64: Handle PSCI resets before userspace touches vCPU state
authorOliver Upton <oupton@google.com>
Wed, 18 Aug 2021 20:21:31 +0000 (20:21 +0000)
committerMarc Zyngier <maz@kernel.org>
Thu, 19 Aug 2021 08:08:56 +0000 (09:08 +0100)
commit6826c6849b46aaa91300201213701eb861af4ba0
tree7277b36bf4bd3c9705779d910a6ed87911d7f333
parent6654f9dfcb88fea3b9affc180dc3c04333d0f306
KVM: arm64: Handle PSCI resets before userspace touches vCPU state

The CPU_ON PSCI call takes a payload that KVM uses to configure a
destination vCPU to run. This payload is non-architectural state and not
exposed through any existing UAPI. Effectively, we have a race between
CPU_ON and userspace saving/restoring a guest: if the target vCPU isn't
ran again before the VMM saves its state, the requested PC and context
ID are lost. When restored, the target vCPU will be runnable and start
executing at its old PC.

We can avoid this race by making sure the reset payload is serviced
before userspace can access a vCPU's state.

Fixes: 358b28f09f0a ("arm/arm64: KVM: Allow a VCPU to fully reset itself")
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210818202133.1106786-3-oupton@google.com
arch/arm64/kvm/arm.c