USB: serial: keyspan_pda: fix dropped unthrottle interrupts
authorJohan Hovold <johan@kernel.org>
Sun, 25 Oct 2020 17:45:47 +0000 (18:45 +0100)
committerJohan Hovold <johan@kernel.org>
Wed, 4 Nov 2020 10:00:17 +0000 (11:00 +0100)
commit696c541c8c6cfa05d65aa24ae2b9e720fc01766e
tree398caa6edd145fa522a316de3b907102f4bc8d14
parentd1849b9ff9f442b3720e07b2d6f6c5cf1b97b1a3
USB: serial: keyspan_pda: fix dropped unthrottle interrupts

Commit c528fcb116e6 ("USB: serial: keyspan_pda: fix receive sanity
checks") broke write-unthrottle handling by dropping well-formed
unthrottle-interrupt packets which are precisely two bytes long. This
could lead to blocked writers not being woken up when buffer space again
becomes available.

Instead, stop unconditionally printing the third byte which is
(presumably) only valid on modem-line changes.

Fixes: c528fcb116e6 ("USB: serial: keyspan_pda: fix receive sanity checks")
Cc: stable <stable@vger.kernel.org> # 4.11
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/keyspan_pda.c