target/i386: cleanup eob handling of RSM
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 16 May 2024 16:43:44 +0000 (18:43 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 25 May 2024 11:28:01 +0000 (13:28 +0200)
commit69d728126223941de298b34798eb433be28b2734
tree9a0285da6c1f0677aa5a6aab31bbc9fd18768679
parentf0f0136abba688a6516647a79cc91e03fad6d5d7
target/i386: cleanup eob handling of RSM

gen_helper_rsm cannot generate an exception, and reloads the flags.
So there's no need to spill cc_op and update cpu_eip, but on the
other hand cc_op must be reset to CC_OP_EFLAGS before returning.

It all works by chance, because by spilling cc_op before the call
to the helper, it becomes non-dirty and gen_eob will not overwrite
the CC_OP_EFLAGS value that is placed there by the helper.  But
let's clean it up.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/tcg/translate.c