hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Wed, 18 Oct 2023 07:53:43 +0000 (09:53 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 20 Oct 2023 12:46:07 +0000 (14:46 +0200)
commit6a7f9f6f90dd7ecb137c1772cb98134d7606cdc3
tree7d4f19d8f0a2e1bac30ae866f6c4f6f236b503db
parente29c4cb05ed9858f408db6b8fa775bc76f27a541
hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region

There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.

Just map it without using the SysBus API.

Transformation done using the following coccinelle script:

  @@
  expression sbdev;
  expression index;
  expression addr;
  expression subregion;
  @@
  -    sysbus_init_mmio(sbdev, subregion);
       ... when != sbdev
  -    sysbus_mmio_map(sbdev, index, addr);
  +    memory_region_add_subregion(get_system_memory(), addr, subregion);

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20231019131647.19690-5-philmd@linaro.org>
hw/ppc/pnv_xscom.c