drm/v3d: Fix race-condition between sysfs/fdinfo and interrupt handler
authorMaíra Canal <mcanal@igalia.com>
Sat, 20 Apr 2024 21:32:13 +0000 (18:32 -0300)
committerMaíra Canal <mcanal@igalia.com>
Tue, 23 Apr 2024 22:32:49 +0000 (19:32 -0300)
commit6abe93b621ab12e93cf0eb7e42a609b36be32da1
tree2dcd038c91e82421c87eec1da93e3a2149f18d5f
parent12d1624ce3d3fb030180384f9725d059538e5605
drm/v3d: Fix race-condition between sysfs/fdinfo and interrupt handler

In V3D, the conclusion of a job is indicated by a IRQ. When a job
finishes, then we update the local and the global GPU stats of that
queue. But, while the GPU stats are being updated, a user might be
reading the stats from sysfs or fdinfo.

For example, on `gpu_stats_show()`, we could think about a scenario where
`v3d->queue[queue].start_ns != 0`, then an interrupt happens, we update
the value of `v3d->queue[queue].start_ns` to 0, we come back to
`gpu_stats_show()` to calculate `active_runtime` and now,
`active_runtime = timestamp`.

In this simple example, the user would see a spike in the queue usage,
that didn't match reality.

In order to address this issue properly, use a seqcount to protect read
and write sections of the code.

Fixes: 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo() callback for GPU usage stats")
Reported-by: Tvrtko Ursulin <tursulin@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240420213632.339941-7-mcanal@igalia.com
drivers/gpu/drm/v3d/v3d_drv.c
drivers/gpu/drm/v3d/v3d_drv.h
drivers/gpu/drm/v3d/v3d_gem.c
drivers/gpu/drm/v3d/v3d_sched.c