vhost-vdpa: backend feature should set only once
authorSi-Wei Liu <si-wei.liu@oracle.com>
Sat, 7 May 2022 02:28:16 +0000 (19:28 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 16 May 2022 20:15:41 +0000 (16:15 -0400)
commit6aee7e4233f6467f69531fcd352adff028f3f5ea
tree24d52d877a59592b38c993289fccef1146adcbb5
parent6f3910b5eee00b8cc959e94659c0d524c482a418
vhost-vdpa: backend feature should set only once

The vhost_vdpa_one_time_request() branch in
vhost_vdpa_set_backend_cap() incorrectly sends down
ioctls on vhost_dev with non-zero index. This may
end up with multiple VHOST_SET_BACKEND_FEATURES
ioctl calls sent down on the vhost-vdpa fd that is
shared between all these vhost_dev's.

To fix it, send down ioctl only once via the first
vhost_dev with index 0. Toggle the polarity of the
vhost_vdpa_one_time_request() test should do the
trick.

Fixes: 4d191cfdc7de ("vhost-vdpa: classify one time request")
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <1651890498-24478-6-git-send-email-si-wei.liu@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost-vdpa.c