drm/nouveau/svm: Fix refcount leak bug and missing check against null bug
authorChenyuan Mi <cymi20@fudan.edu.cn>
Tue, 7 Sep 2021 12:26:33 +0000 (20:26 +0800)
committerKarol Herbst <kherbst@redhat.com>
Thu, 4 Nov 2021 11:29:07 +0000 (12:29 +0100)
commit6bb8c2d51811eb5e6504f49efe3b089d026009d2
tree397549feef0b9b03ae95b91220d97f07090c4088
parent93f43ed81abec8c805e1b77eb1d20dbc51a24dc4
drm/nouveau/svm: Fix refcount leak bug and missing check against null bug

The reference counting issue happens in one exception handling path of
nouveau_svmm_bind(). When cli->svm.svmm is null, the function forgets
to decrease the refcount of mm increased by get_task_mm(), causing a
refcount leak.

Fix this issue by using mmput() to decrease the refcount in the
exception handling path.

Also, the function forgets to do check against null when get mm
by get_task_mm().

Fix this issue by adding null check after get mm by get_task_mm().

Signed-off-by: Chenyuan Mi <cymi20@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Fixes: 822cab6150d3 ("drm/nouveau/svm: check for SVM initialized before migrating")
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210907122633.16665-1-cymi20@fudan.edu.cn
Link: https://gitlab.freedesktop.org/drm/nouveau/-/merge_requests/14
drivers/gpu/drm/nouveau/nouveau_svm.c