serial: pch: move size check from pop_tx one level up
authorJiri Slaby <jslaby@suse.cz>
Tue, 3 May 2022 08:06:07 +0000 (10:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 May 2022 20:42:45 +0000 (22:42 +0200)
commit6c1f77c3781a893cabe04b560a63b0524fe458f3
tree2134173ae20755c51f66911664a429eef7dc4c2a
parentdfb9afb6c0e7af7c381c88d72d6d9c64268c160f
serial: pch: move size check from pop_tx one level up

'count' is zero in the pop_tx()'s comparison against 'size'. So the 'if'
tries to find out if 'size' is negative or zero and returns in that
case. But it cannot be negative, due to previous (size < 0) check in the
caller: handle_tx().

So simply move this check from pop_tx() to handle_tx(). Now it's clear
that pop_tx() is called only if fifo_size is non-zero.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220503080613.27601-2-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c