ice: dpll: fix output pin capabilities
authorArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tue, 31 Oct 2023 17:08:00 +0000 (18:08 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 13 Nov 2023 18:56:38 +0000 (10:56 -0800)
commit6db5f2cd9ebb12e930a82c01714a6589576cd50f
tree52d2281fda8b2bcf239ae7f2ec685d5a7e344f99
parent4a4027f25dc3f39c2aafb3bf8926125c5378c9dc
ice: dpll: fix output pin capabilities

The dpll output pins which are used to feed clock signal of PHY and MAC
circuits cannot be disconnected, those integrated circuits require clock
signal for operation.
By stopping assignment of DPLL_PIN_CAPABILITIES_STATE_CAN_CHANGE pin
capability, prevent the user from invoking the state set callback on
those pins, setting the state on those pins already returns error, as
firmware doesn't allow the change of their state.

Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
Fixes: 8a3a565ff210 ("ice: add admin commands to access cgu configuration")
Reviewed-by: Andrii Staikov <andrii.staikov@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_dpll.c
drivers/net/ethernet/intel/ice/ice_ptp_hw.c
drivers/net/ethernet/intel/ice/ice_ptp_hw.h