igc: Refactor runtime power management flow
authorSasha Neftin <sasha.neftin@intel.com>
Sun, 11 Feb 2024 07:30:58 +0000 (09:30 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 29 Mar 2024 15:58:43 +0000 (08:58 -0700)
commit6f31d6b643a32cc126cf86093fca1ea575948bf0
treedf9216bbb7ddc2fac88bf5739be19ed3d0640ec1
parent75a3f93b53832449c2c58a527a3865394cc656ba
igc: Refactor runtime power management flow

Following the corresponding discussion [1] and [2] refactor the 'igc_open'
method and avoid taking the rtnl_lock() during the 'igc_resume' method.
The rtnl_lock is held by the upper layer and could lead to the deadlock
during resuming from a runtime power management flow. Notify the stack of
the actual queue counts 'netif_set_real_num_*_queues' outside the
'_igc_open' wrapper. This notification doesn't have to be called on each
resume.

Test:
1. Disconnect the ethernet cable
2. Enable the runtime power management via file system:
echo auto > /sys/devices/pci0000\.../power/control
3. Check the device state (lspci -s <device> -vvv | grep -i Status)

Link: https://lore.kernel.org/netdev/20231206113934.8d7819857574.I2deb5804
ef1739a2af307283d320ef7d82456494@changeid/#r [1]
Link: https://lore.kernel.org/netdev/20211125074949.5f897431@kicinski-fedo
ra-pc1c0hjn.dhcp.thefacebook.com/t/ [2]
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_main.c