devlink: make health report on unregistered instance warn just once
authorJakub Kicinski <kuba@kernel.org>
Wed, 31 May 2023 01:55:23 +0000 (18:55 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Jun 2023 05:34:22 +0000 (22:34 -0700)
commit6f4b98147b8dfcabacb19b5c6abd087af66d0049
tree6eee95ecdacbd7e0dfb8f334f2367ad48b11f3d0
parent6f7aee27b1bb5c5aab0813af20dda172b6a6ecab
devlink: make health report on unregistered instance warn just once

Devlink health is involved in error recovery. Machines in bad
state tend to be fairly unreliable, and occasionally get stuck
in error loops. Even with a reasonable grace period devlink health
may get a thousand reports in an hour.

In case of reporting on an unregistered devlink instance
the subsequent reports don't add much value. Switch to
WARN_ON_ONCE() to avoid flooding dmesg and fleet monitoring
dashboards.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20230531015523.48961-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/devlink/health.c