cpu/hotplug: Do not bail-out in DYING/STARTING sections
authorVincent Donnefort <vdonnefort@google.com>
Tue, 27 Sep 2022 10:12:59 +0000 (11:12 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 2 Dec 2022 11:43:02 +0000 (12:43 +0100)
commit6f855b39e4602b6b42a8e5cbcfefb8a1b8b5f0be
tree616ce00adab95c5d7fc977db8ffb4a8deaca8366
parentd385febc9a19635d4ef197bfad3e84729002f57c
cpu/hotplug: Do not bail-out in DYING/STARTING sections

The DYING/STARTING callbacks are not expected to fail. However, as reported
by Derek, buggy drivers such as tboot are still free to return errors
within those sections, which halts the hot(un)plug and leaves the CPU in an
unrecoverable state.

As there is no rollback possible, only log the failures and proceed with
the following steps.

This restores the hotplug behaviour prior to commit 453e41085183
("cpu/hotplug: Add cpuhp_invoke_callback_range()")

Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
Reported-by: Derek Dolney <z23@posteo.net>
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Derek Dolney <z23@posteo.net>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
Link: https://lore.kernel.org/r/20220927101259.1149636-1-vdonnefort@google.com
kernel/cpu.c