io_uring/af_unix: disable sending io_uring over sockets
authorPavel Begunkov <asml.silence@gmail.com>
Wed, 6 Dec 2023 13:26:47 +0000 (13:26 +0000)
committerJens Axboe <axboe@kernel.dk>
Thu, 7 Dec 2023 17:35:19 +0000 (10:35 -0700)
commit705318a99a138c29a512a72c3e0043b3cd7f55f4
tree444eddc451943aaed9443fd81c1f8c13150110e0
parent9865346b7e8374b57f1c3ccacdc77846c6352ff4
io_uring/af_unix: disable sending io_uring over sockets

File reference cycles have caused lots of problems for io_uring
in the past, and it still doesn't work exactly right and races with
unix_stream_read_generic(). The safest fix would be to completely
disallow sending io_uring files via sockets via SCM_RIGHT, so there
are no possible cycles invloving registered files and thus rendering
SCM accounting on the io_uring side unnecessary.

Cc: <stable@vger.kernel.org>
Fixes: 0091bfc81741b ("io_uring/af_unix: defer registered files gc to io_uring release")
Reported-and-suggested-by: Jann Horn <jannh@google.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/c716c88321939156909cfa1bd8b0faaf1c804103.1701868795.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/rsrc.h
net/core/scm.c