wifi: iwlwifi: fw: replace deprecated strncpy with strscpy_pad
authorJustin Stitt <justinstitt@google.com>
Thu, 19 Oct 2023 17:44:59 +0000 (17:44 +0000)
committerKalle Valo <kvalo@kernel.org>
Fri, 1 Dec 2023 12:38:16 +0000 (14:38 +0200)
commit70582e26f5d9a94b373f925186c03455849fd3db
treefbeb4badfe4f6d271d3cc7ae1d8adfa628505854
parent9f4dee32b783955f35b74609241db76f625f2ec3
wifi: iwlwifi: fw: replace deprecated strncpy with strscpy_pad

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

Based on the deliberate `sizeof(dest) ... - 1` pattern we can see that
both dump_info->dev_human_readable and dump_info->bus_human_readable are
intended to be NUL-terminated.

Moreover, since this seems to cross the file boundary let's NUL-pad to
ensure no behavior change.

strscpy_pad() covers both the NUL-termination and NUL-padding, let's use
it.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231019-strncpy-drivers-net-wireless-intel-iwlwifi-fw-dbg-c-v2-1-179b211a374b@google.com
drivers/net/wireless/intel/iwlwifi/fw/dbg.c