netlink: Bounds-check struct nlmsgerr creation
authorKees Cook <keescook@chromium.org>
Sat, 3 Sep 2022 04:37:49 +0000 (21:37 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Sep 2022 13:45:22 +0000 (14:45 +0100)
commit710d21fdff9a98d621cd4e64167f3ef8af4e2fd1
treec039cd1cbfc4dc5dc57138e1d5752e155810be5a
parent05ad5d4581c3c1cc724fe50d4652833fb9f3037b
netlink: Bounds-check struct nlmsgerr creation

In preparation for FORTIFY_SOURCE doing bounds-check on memcpy(),
switch from __nlmsg_put to nlmsg_put(), and explain the bounds check
for dealing with the memcpy() across a composite flexible array struct.
Avoids this future run-time warning:

  memcpy: detected field-spanning write (size 32) of single field "&errmsg->msg" at net/netlink/af_netlink.c:2447 (size 16)

Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: syzbot <syzkaller@googlegroups.com>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220901071336.1418572-1-keescook@chromium.org
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/ipset/ip_set_core.c
net/netlink/af_netlink.c