python/machine: add instance disambiguator to default nickname
authorJohn Snow <jsnow@redhat.com>
Thu, 18 Nov 2021 20:46:16 +0000 (15:46 -0500)
committerJohn Snow <jsnow@redhat.com>
Mon, 22 Nov 2021 23:40:59 +0000 (18:40 -0500)
commit72b17fe715056c96ea73f187ab46721788b3a782
tree3a318ab3084c2ee6e8ad3b5f7ad020b194e861a6
parent6eeb3de7e1aff91ce6e092a39f85946d12664385
python/machine: add instance disambiguator to default nickname

If you create two instances of QEMUMachine(), they'll both create the
same nickname by default -- which is not that helpful.

Luckily, they'll both create unique temporary directories ... but due to
user configuration, they may share logging and sockfile directories,
meaning two instances can collide. The Python logging will also be quite
confusing, with no differentiation between the two instances.

Add an instance disambiguator (The memory address of the instance) to
the default nickname to foolproof this in all cases.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-id: 20211118204620.1897674-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/machine/machine.py