drm/virtio: Fix error code in virtio_gpu_object_shmem_init()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 2 Mar 2023 17:25:38 +0000 (09:25 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:57:40 +0000 (13:57 +0100)
commit72bf6d493c959aaa15e79bc828801ef2494dc429
treeb1662b425b38ebf175a4de0780fb757b26a62636
parent8e62139840c077a3c17d9b815053f1bf11e23689
drm/virtio: Fix error code in virtio_gpu_object_shmem_init()

In virtio_gpu_object_shmem_init() we are passing NULL to PTR_ERR, which
is returning 0/success.

Fix this by storing error value in 'ret' variable before assigning
shmem->pages to NULL.

Found using static analysis with Smatch.

Fixes: 64b88afbd92f ("drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/virtio/virtgpu_object.c