drm: Fix output poll work for drm_kms_helper_poll=n
authorImre Deak <imre.deak@intel.com>
Fri, 1 Mar 2024 15:22:43 +0000 (17:22 +0200)
committerImre Deak <imre.deak@intel.com>
Mon, 4 Mar 2024 12:15:51 +0000 (14:15 +0200)
commit72e6d668773fd19f78a6e8017347b08a5cccaaeb
tree2312c41e235e68c495e59de2272a3b8936d18382
parentc70703320e557ff30847915e6a7631a9abdda16b
drm: Fix output poll work for drm_kms_helper_poll=n

If drm_kms_helper_poll=n the output poll work will only get scheduled
from drm_helper_probe_single_connector_modes() to handle a delayed
hotplug event. Since polling is disabled the work in this case should
just call drm_kms_helper_hotplug_event() w/o detecting the state of
connectors and rescheduling the work.

After commit d33a54e3991d after a delayed hotplug event above the
connectors did get re-detected in the poll work and the work got
re-scheduled periodically (since poll_running is also false if
drm_kms_helper_poll=n), in effect ignoring the drm_kms_helper_poll=n
kernel param.

Fix the above by calling only drm_kms_helper_hotplug_event() for a
delayed hotplug event if drm_kms_helper_hotplug_event=n, as was done
before d33a54e3991d.

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: d33a54e3991d ("drm/probe_helper: sort out poll_running vs poll_enabled")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240301152243.1670573-1-imre.deak@intel.com
drivers/gpu/drm/drm_probe_helper.c