crypto: marvell/octeontx - fix double free of ptr
authorColin Ian King <colin.king@canonical.com>
Wed, 1 Apr 2020 23:10:12 +0000 (00:10 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 3 Apr 2020 04:37:26 +0000 (15:37 +1100)
commit755bddd1e4eaf9178758bd554c60aaab46fc42ba
tree16765832160e4549ab98088c9ec5eec208de5c4b
parentb5f13031cd8da1b8f1e277d03a773dc46f7cff11
crypto: marvell/octeontx - fix double free of ptr

Currently in the case where eq->src != req->ds, the allocation of
ptr is kfree'd at the end of the code block. However later on in
the case where enc is not null any of the error return paths that
return via the error handling return path end up performing an
erroneous second kfree of ptr.

Fix this by adding an error exit label error_free and only jump to
this when ptr needs kfree'ing thus avoiding the double free issue.

Addresses-Coverity: ("Double free")
Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx/otx_cptvf_algs.c