drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c
authorZhao Liu <zhao1.liu@intel.com>
Sun, 3 Dec 2023 13:29:41 +0000 (21:29 +0800)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Fri, 15 Dec 2023 09:34:28 +0000 (09:34 +0000)
commit756eed0f2602f73df8d6c5bc8418ecd11cce9803
tree91be7e8f76412d1303d69f07bed3bc0ecc206154
parentf4d88908cd9a430a7473eea6ff2300a3b728e11c
drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

The use of kmap_atomic() is being deprecated in favor of
kmap_local_page()[1].

The main difference between atomic and local mappings is that local
mappings doesn't disable page faults or preemption (the preemption is
disabled for !PREEMPT_RT case, otherwise it only disables migration).

With kmap_local_page(), we can avoid the often unwanted side effect of
unnecessary page faults or preemption disables.

In drm/i915/gem/i915_gem_shmem.c, the function shmem_pwrite() need to
disable pagefault to eliminate the potential recursion fault[2]. But
here __copy_from_user_inatomic() doesn't need to disable preemption and
local mapping is valid for sched in/out.

So it can use kmap_local_page() / kunmap_local() with
pagefault_disable() / pagefault_enable() to replace atomic mapping.

[1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
[2]: https://patchwork.freedesktop.org/patch/295840/

Suggested-by: Ira Weiny <ira.weiny@intel.com>
Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231203132947.2328805-4-zhao1.liu@linux.intel.com
drivers/gpu/drm/i915/gem/i915_gem_shmem.c