dax: refactor deprecated strncpy
authorJustin Stitt <justinstitt@google.com>
Wed, 13 Sep 2023 01:10:24 +0000 (01:10 +0000)
committerIra Weiny <ira.weiny@intel.com>
Wed, 27 Sep 2023 17:33:46 +0000 (10:33 -0700)
commit75b3d5dc0846cfa54ea52d7d84215b761ecbf569
treeda4d6b0567d87b81228938d896792d46bd2075d7
parent6465e260f48790807eef06b583b38ca9789b6072
dax: refactor deprecated strncpy

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

We should prefer more robust and less ambiguous string interfaces.

`dax_id->dev_name` is expected to be NUL-terminated and has been zero-allocated.

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer. Moreover, due to
`dax_id` being zero-allocated the padding behavior of `strncpy` is not
needed and a simple 1:1 replacement of strncpy -> strscpy should
suffice.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
drivers/dax/bus.c