igc: Remove redundant runtime resume for ethtool ops
authorBjorn Helgaas <bhelgaas@google.com>
Mon, 25 Mar 2024 22:29:51 +0000 (17:29 -0500)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 8 Apr 2024 20:25:39 +0000 (13:25 -0700)
commit75f16e06dfb8035a89548ca33d26b362c934acc9
treea8fbd66b83cd44d0c1ac3c88bf81070f86ccbd5d
parent461359c4f3700b4bc4da0c3358be423296ee6561
igc: Remove redundant runtime resume for ethtool ops

8c5ad0dae93c ("igc: Add ethtool support") added ethtool_ops.begin() and
.complete(), which used pm_runtime_get_sync() to resume suspended devices
before any ethtool_ops callback and allow suspend after it completed.

Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
so the device is resumed before any ethtool_ops callback even if the driver
didn't supply a .begin() callback.

Remove the .begin() and .complete() callbacks, which are now redundant
because dev_ethtool() already resumes the device.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_ethtool.c