leds: pwm: Don't disable the PWM when the LED should be off
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 22 Sep 2023 19:28:34 +0000 (21:28 +0200)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:50 +0000 (11:28 +0000)
commit76fe464c8e64e71b2e4af11edeef0e5d85eeb6aa
treeb6fafdd5cc328d8dad2048df8111b281115c42b7
parent43e9082fbccc7df8b2028c1ba040c58cefda703f
leds: pwm: Don't disable the PWM when the LED should be off

Disabling a PWM (i.e. calling pwm_apply_state with .enabled = false)
gives no guarantees what the PWM output does. It might freeze where it
currently is, or go in a High-Z state or drive the active or inactive
state, it might even continue to toggle.

To ensure that the LED gets really disabled, don't disable the PWM even
when .duty_cycle is zero.

This fixes disabling a leds-pwm LED on i.MX28. The PWM on this SoC is
one of those that freezes its output on disable, so if you disable an
LED that is full on, it stays on. If you disable a LED with half
brightness it goes off in 50% of the cases and full on in the other 50%.

Fixes: 41c42ff5dbe2 ("leds: simple driver for pwm driven LEDs")
Reported-by: Rogan Dawes <rogan@dawes.za.net>
Reported-by: Fabio Estevam <festevam@denx.de>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Link: https://lore.kernel.org/r/20230922192834.1695727-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-pwm.c