bpf: improve error message for unsupported helper
authorMykyta Yatsenko <yatsenko@meta.com>
Mon, 25 Mar 2024 15:22:10 +0000 (15:22 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 29 Mar 2024 01:30:53 +0000 (18:30 -0700)
commit786bf0e7e2ec90b349a7bab6e97947982ab31f2c
tree06035090d80edace56555e7454bc414989f07903
parent59b418c7063d30e0a3e1f592d47df096db83185c
bpf: improve error message for unsupported helper

BPF verifier emits "unknown func" message when given BPF program type
does not support BPF helper. This message may be confusing for users, as
important context that helper is unknown only to current program type is
not provided.

This patch changes message to "program of this type cannot use helper "
and aligns dependent code in libbpf and tests. Any suggestions on
improving/changing this message are welcome.

Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/r/20240325152210.377548-1-yatsenko@meta.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c
tools/bpf/bpftool/feature.c
tools/lib/bpf/libbpf_probes.c
tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
tools/testing/selftests/bpf/progs/verifier_helper_restricted.c