dm-verity, dm-crypt: align "struct bvec_iter" correctly
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 20 Feb 2024 18:11:51 +0000 (19:11 +0100)
committerMike Snitzer <snitzer@kernel.org>
Tue, 20 Feb 2024 18:34:32 +0000 (13:34 -0500)
commit787f1b2800464aa277236a66eb3c279535edd460
tree03a370dd0d630c2285e52ef27bd9e85b18bf5f3a
parent42e15d12070b4ff9af2b980f1b65774c2dab0507
dm-verity, dm-crypt: align "struct bvec_iter" correctly

"struct bvec_iter" is defined with the __packed attribute, so it is
aligned on a single byte. On X86 (and on other architectures that support
unaligned addresses in hardware), "struct bvec_iter" is accessed using the
8-byte and 4-byte memory instructions, however these instructions are less
efficient if they operate on unaligned addresses.

(on RISC machines that don't have unaligned access in hardware, GCC
generates byte-by-byte accesses that are very inefficient - see [1])

This commit reorders the entries in "struct dm_verity_io" and "struct
convert_context", so that "struct bvec_iter" is aligned on 8 bytes.

[1] https://lore.kernel.org/all/ZcLuWUNRZadJr0tQ@fedora/T/

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-crypt.c
drivers/md/dm-verity.h