ssb: Fix potential NULL pointer dereference in ssb_device_uevent()
authorRand Deeb <rand.sec96@gmail.com>
Wed, 6 Mar 2024 12:30:28 +0000 (15:30 +0300)
committerKalle Valo <kvalo@kernel.org>
Tue, 12 Mar 2024 15:31:11 +0000 (17:31 +0200)
commit789c17185fb0f39560496c2beab9b57ce1d0cbe7
tree970a700cbc940806aef7e5c353bffcb1ceb49b02
parentf1dfcee2eae98abbdb677b872f091b1589a9cfed
ssb: Fix potential NULL pointer dereference in ssb_device_uevent()

The ssb_device_uevent() function first attempts to convert the 'dev' pointer
to 'struct ssb_device *'. However, it mistakenly dereferences 'dev' before
performing the NULL check, potentially leading to a NULL pointer
dereference if 'dev' is NULL.

To fix this issue, move the NULL check before dereferencing the 'dev' pointer,
ensuring that the pointer is valid before attempting to use it.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Rand Deeb <rand.sec96@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240306123028.164155-1-rand.sec96@gmail.com
drivers/ssb/main.c