dmaengine: rcar-dmac: Reject zero-length slave DMA requests
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 24 Jun 2019 12:38:18 +0000 (14:38 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 25 Jun 2019 04:38:22 +0000 (10:08 +0530)
commit78efb76ab4dfb8f74f290ae743f34162cd627f19
tree7adc73ab2784f6c29cdb35e0380f561006bf166c
parent9e5ab0655ef98cc1261409f94a42219dfb68cc22
dmaengine: rcar-dmac: Reject zero-length slave DMA requests

While the .device_prep_slave_sg() callback rejects empty scatterlists,
it still accepts single-entry scatterlists with a zero-length segment.
These may happen if a driver calls dmaengine_prep_slave_single() with a
zero len parameter.  The corresponding DMA request will never complete,
leading to messages like:

    rcar-dmac e7300000.dma-controller: Channel Address Error happen

and DMA timeouts.

Although requesting a zero-length DMA request is a driver bug, rejecting
it early eases debugging.  Note that the .device_prep_dma_memcpy()
callback already rejects requests to copy zero bytes.

Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Analyzed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/rcar-dmac.c