leds: ns2: Add of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Tue, 16 Jul 2019 07:24:24 +0000 (12:54 +0530)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Mon, 22 Jul 2019 18:35:00 +0000 (20:35 +0200)
commit79937a4beeaeb3e2584db5dfe3a7c9ee3d5f97f6
treeb73ab1c5a037919a43485c3456055408a0ab7e73
parent730f693d79da8130c8ac18d1083cdb333fd8d7c8
leds: ns2: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence create a new label, err_node_put, that puts
the previous node before returning the required value. Edit the mid-loop
return sites to instead go to this new label.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-ns2.c