PCI: keystone: Don't discard .probe() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 1 Oct 2023 17:02:54 +0000 (19:02 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 10 Oct 2023 17:13:17 +0000 (12:13 -0500)
commit7994db905c0fd692cf04c527585f08a91b560144
tree1b6cf47e0d0b248031031b5e2d3db899d71f0e0a
parent200bddbb3f5202bbce96444fdc416305de14f547
PCI: keystone: Don't discard .probe() callback

The __init annotation makes the ks_pcie_probe() function disappear after
booting completes. However a device can also be bound later. In that case,
we try to call ks_pcie_probe(), but the backing memory is likely already
overwritten.

The right thing to do is do always have the probe callback available.  Note
that the (wrong) __refdata annotation prevented this issue to be noticed by
modpost.

Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
Link: https://lore.kernel.org/r/20231001170254.2506508-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pci-keystone.c