hw/openrisc: Fixed undercounting of TTCR in continuous mode
authorJoel Holdsworth <jholdsworth@nvidia.com>
Fri, 7 Jun 2024 22:29:33 +0000 (15:29 -0700)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 3 Dec 2024 11:26:24 +0000 (12:26 +0100)
commit79b38d61b53ffba95dcbf5ff6a1ba8f6f4eefbef
treedbc11d95b851fea47f38e1b2a5361e495e828e37
parenteb22a064455aeebc105cc89bf77f48aa18b52938
hw/openrisc: Fixed undercounting of TTCR in continuous mode

In the existing design, TTCR is prone to undercounting when running in
continuous mode. This manifests as a timer interrupt appearing to
trigger a few cycles prior to the deadline set in SPR_TTMR_TP.

When the timer triggers, the virtual time delta in nanoseconds between
the time when the timer was set, and when it triggers is calculated.
This nanoseconds value is then divided by TIMER_PERIOD (50) to compute
an increment of cycles to apply to TTCR.

However, this calculation rounds down the number of cycles causing the
undercounting.

A simplistic solution would be to instead round up the number of cycles,
however this will result in the accumulation of timing error over time.

This patch corrects the issue by calculating the time delta in
nanoseconds between when the timer was last reset and the timer event.
This approach allows the TTCR value to be rounded up, but without
accumulating error over time.

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
[stafford: Incremented version in vmstate_or1k_timer, checkpatch fixes]
Signed-off-by: Stafford Horne <shorne@gmail.com>
Message-ID: <20241203110536.402131-3-shorne@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/openrisc/cputimer.c