staging: r8188eu: release_firmware is not called if allocation fails
authorMichael Straube <straube.linux@gmail.com>
Fri, 7 Jan 2022 10:36:04 +0000 (11:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:43 +0000 (14:23 +0200)
commit7a68abde36e1480fa4ad08a3229bb8d6a5355d47
tree62090af0a4485d601e6b9557fbdcd4a7e0e692f8
parent1768384f61d10dd33975615ce44e5185711abf09
staging: r8188eu: release_firmware is not called if allocation fails

[ Upstream commit 39850edf2befe27bcb3d6c37b6ee76d2ee4df903 ]

In function load_firmware() release_firmware() is not called if the
allocation of pFirmware->szFwBuffer fails or if fw->size is greater
than FW_8188E_SIZE.

Move the call to release_firmware() to the exit label at the end of
the function to fix this.

Fixes: 8cd574e6af54 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver")
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220107103620.15648-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c