iio: adc: max11410: fix read_poll_timeout() usage
authorNuno Sá <nuno.sa@analog.com>
Tue, 7 Mar 2023 09:53:03 +0000 (10:53 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 12 Mar 2023 15:25:24 +0000 (15:25 +0000)
commit7b3825e9487d77e83bf1e27b10a74cd729b8f972
tree2662313ed720674607bac094dcbdc4c3407c5aac
parentc3701185ee1973845db088d8b0fc443397ab0eb2
iio: adc: max11410: fix read_poll_timeout() usage

Even though we are passing 'ret' as stop condition for
read_poll_timeout(), that return code is still being ignored. The reason
is that the poll will stop if the passed condition is true which will
happen if the passed op() returns error. However, read_poll_timeout()
returns 0 if the *complete* condition evaluates to true. Therefore, the
error code returned by op() will be ignored.

To fix this we need to check for both error codes:
 * The one returned by read_poll_timeout() which is either 0 or
ETIMEDOUT.
 * The one returned by the passed op().

Fixes: a44ef7c46097 ("iio: adc: add max11410 adc driver")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Acked-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Link: https://lore.kernel.org/r/20230307095303.713251-1-nuno.sa@analog.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/max11410.c