hw/display: check frame buffer can hold blob
authorAlex Bennée <alex.bennee@linaro.org>
Mon, 11 Nov 2024 23:00:40 +0000 (23:00 +0000)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 18 Nov 2024 12:36:39 +0000 (13:36 +0100)
commit7b5574225429621e7122a83c06d1b23931f152df
treec5b515c14ae8f51257e4197287522c5797cd273f
parentc4e1c361b342ccff11df6748198b1e0bcad9b635
hw/display: check frame buffer can hold blob

Coverity reports (CID 15647691564770) that we potentially overflow
by doing some 32x32 multiplies for something that ends up in a 64 bit
value. Fix this by first using stride for all lines and casting input
to uint64_t to ensure a 64 bit multiply is used.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Message-ID: <20241111230040.68470-3-alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/display/virtio-gpu.c
include/hw/virtio/virtio-gpu.h