firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT
authorSudeep Holla <sudeep.holla@arm.com>
Mon, 11 Nov 2019 16:25:22 +0000 (16:25 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Thu, 14 Nov 2019 11:13:50 +0000 (11:13 +0000)
commit7bd39bc6bfdf96f5df0f92199bbc1a3ee2f2adb8
tree6da77533df70498d664575db08cb179f2ac8afe3
parent54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT

The logic to ring the scmi performance fastchannel ignores the
value read from the doorbell register in case of !CONFIG_64BIT.
This bug also shows up as warning with '-Wunused-but-set-variable' gcc
flag:

drivers/firmware/arm_scmi/perf.c: In function scmi_perf_fc_ring_db:
drivers/firmware/arm_scmi/perf.c:323:7: warning: variable val set but
not used [-Wunused-but-set-variable]

Fix the same by aligning the logic with CONFIG_64BIT as used in the
macro SCMI_PERF_FC_RING_DB().

Fixes: 823839571d76 ("firmware: arm_scmi: Make use SCMI v2.0 fastchannel for performance protocol")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reported-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/perf.c