serial: core: only stop transmit when HW fifo is empty
authorJonas Gorski <jonas.gorski@gmail.com>
Sun, 3 Mar 2024 15:08:07 +0000 (16:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Mar 2024 13:37:29 +0000 (13:37 +0000)
commit7bfb915a597a301abb892f620fe5c283a9fdbd77
treeea89f5a9ee6ac60d18ff4cfe62c6cfbf0c371e0d
parentd47dd323bf959dbf5f3e7f83373c8ed5f3bec9c0
serial: core: only stop transmit when HW fifo is empty

If the circular buffer is empty, it just means we fit all characters to
send into the HW fifo, but not that the hardware finished transmitting
them.

So if we immediately call stop_tx() after that, this may abort any
pending characters in the HW fifo, and cause dropped characters on the
console.

Fix this by only stopping tx when the tx HW fifo is actually empty.

Fixes: 8275b48b2780 ("tty: serial: introduce transmit helpers")
Cc: stable@vger.kernel.org
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://lore.kernel.org/r/20240303150807.68117-1-jonas.gorski@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/serial_core.h