bpf: Clarify error expectations from bpf_clone_redirect
authorStanislav Fomichev <sdf@google.com>
Mon, 11 Sep 2023 19:47:30 +0000 (12:47 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 11 Sep 2023 20:29:19 +0000 (22:29 +0200)
commit7cb779a6867fea00b4209bcf6de2f178a743247d
tree98f3ee67f16f9909d4ed588d5198daa30240bb89
parent9458964a6da621873a92f7cf03242c020799ecd3
bpf: Clarify error expectations from bpf_clone_redirect

Commit 151e887d8ff9 ("veth: Fixing transmit return status for dropped
packets") exposed the fact that bpf_clone_redirect is capable of
returning raw NET_XMIT_XXX return codes.

This is in the conflict with its UAPI doc which says the following:
"0 on success, or a negative error in case of failure."

Update the UAPI to reflect the fact that bpf_clone_redirect can
return positive error numbers, but don't explicitly define
their meaning.

Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230911194731.286342-1-sdf@google.com
include/uapi/linux/bpf.h
tools/include/uapi/linux/bpf.h