bcachefs: Data update path won't accidentaly grow replicas
authorKent Overstreet <kent.overstreet@linux.dev>
Sat, 25 Nov 2023 02:51:45 +0000 (21:51 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 26 Nov 2023 02:48:42 +0000 (21:48 -0500)
commit7d9f8468ff7589073981b3eb8b175945c7dcd13c
tree476fc1bf41080fb88acfc5203974ddd91ee7b1af
parent0af8a06a4ce823e380385cdd9538cdd968a1ffae
bcachefs: Data update path won't accidentaly grow replicas

Previously, there was a bug where if an extent had greater durability
than required (because we needed to move a durability=1 pointer and
ended up putting it on a durability 2 device), we would submit a write
for replicas=2 - the durability of the pointer being rewritten - instead
of the number of replicas required to bring it back up to the
data_replicas option.

This, plus the allocation path sometimes allocating on a greater
durability device than requested, meant that extents could continue
having more and more replicas added as they were being rewritten.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/data_update.c
fs/bcachefs/data_update.h
fs/bcachefs/errcode.h
fs/bcachefs/io_read.c
fs/bcachefs/move.c