wifi: mt7601u: replace strlcpy() with strscpy()
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 13 Jun 2023 00:34:57 +0000 (00:34 +0000)
committerKalle Valo <kvalo@kernel.org>
Thu, 15 Jun 2023 07:46:41 +0000 (10:46 +0300)
commit7edbd53a58a86c1d389e474a4f318cf2fdffa5ce
tree317095f89e8c621aa7f7cf9b9ef75297ce4a0ec6
parent52818fce28b216ef90edbb2b8e134534cf6364c6
wifi: mt7601u: replace strlcpy() with strscpy()

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

Direct replacement is safe here since DEV_ASSIGN is only used by
TRACE macros and the return values are ignored.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230613003458.3538812-1-azeemshaikh38@gmail.com
drivers/net/wireless/mediatek/mt7601u/trace.h